Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request delivers a major refactor focused on modernizing the codebase, enforcing namespaced class usage, and removing all legacy global class aliases and deprecated files. The update improves autoloading, reduces backward compatibility shims, and clarifies documentation to reflect the new canonical patterns for job types and class usage. Existing helper functions remain unchanged for ergonomic reasons, but manual
requirestatements for legacy files should be removed as Composer PSR-4 autoloading is now used throughout.Core refactor and modernization:
class_aliasguards have been removed; only namespaced classes underSoderlind\RedisQueueDemoare supported now. [1] [2]includes/directory and legacy interface stubs (interface-queue-job.php,interface-job-result.php) were deleted; their logic now lives in the canonicalsrc/structure. [1] [2] [3]email_job,Email_Job, etc.) are no longer accepted; only canonical keys likeemail,image_processing,api_syncare valid. [1] [2]Sync_Workerwas removed; only the namespaced worker is supported. [1] [2]Soderlind\RedisQueueDemonamespace, and documentation was updated to reflect these changes and remove legacy references. [1] [2] [3]Documentation and usage updates:
File structure and autoloading:
class-github-plugin-updater.phpwas moved fromincludes/to the plugin root, and all legacy duplicate files were deleted in favor of their namespaced equivalents undersrc/. [1] [2]composer.jsonfile now defines PSR-4 autoloading for the codebase.API and helper function stability:
redis_queue_demo(), etc.) remain unchanged for ergonomic reasons, but manual includes for legacy files should be removed.Admin interface and UI:
src/Admin/partials/. UI element structure and selectors remain stable for backward compatibility.If you encounter missing class errors after upgrading, clear caches and run
composer dump-autoload -o. Please report any backward compatibility regressions in the issue tracker.